Skip to content

Get ICC profile from encoderinfo while PNG saving#1909

Merged
wiredfool merged 2 commits intopython-pillow:masterfrom
uploadcare:png-icc-profile
Jun 25, 2016
Merged

Get ICC profile from encoderinfo while PNG saving#1909
wiredfool merged 2 commits intopython-pillow:masterfrom
uploadcare:png-icc-profile

Conversation

@homm
Copy link
Copy Markdown
Member

@homm homm commented May 12, 2016

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented May 12, 2016

Coverage Status

Changes Unknown when pulling 1a6c6b1 on uploadcare:png-icc-profile into * on python-pillow:master*.

@radarhere
Copy link
Copy Markdown
Member

I presume this is your fix for #1910?

@homm
Copy link
Copy Markdown
Member Author

homm commented May 15, 2016

@radarhere No, this is not related to the data type of ICC profile, only to saving in PNG.

@homm
Copy link
Copy Markdown
Member Author

homm commented Jun 8, 2016

Motivation

Currently JPEG and WEBp both support image.save('out_file', icc_profile=icc_profile), while PNG always get icc_profile from image.info['icc_profile']. This PR allows set icc_profile while saving and also discard icc_profile while saving without removing image.info['icc_profile']:

image.save('out_file', icc_profile=None)

@homm homm mentioned this pull request Jun 21, 2016
@wiredfool wiredfool merged commit 6a3acde into python-pillow:master Jun 25, 2016
@homm homm deleted the png-icc-profile branch July 2, 2016 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants