Skip to content

Add --version argument#580

Merged
Julian merged 3 commits intopython-jsonschema:masterfrom
vladmunteanu:version-argument
Jul 14, 2019
Merged

Add --version argument#580
Julian merged 3 commits intopython-jsonschema:masterfrom
vladmunteanu:version-argument

Conversation

@vladmunteanu
Copy link
Copy Markdown
Contributor

@vladmunteanu vladmunteanu commented Jul 11, 2019

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 11, 2019

Codecov Report

Merging #580 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
+ Coverage   95.61%   95.62%   +<.01%     
==========================================
  Files          19       19              
  Lines        2419     2421       +2     
  Branches      306      306              
==========================================
+ Hits         2313     2315       +2     
  Misses         93       93              
  Partials       13       13

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 11, 2019

Codecov Report

Merging #580 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
+ Coverage   95.61%   95.62%   +<.01%     
==========================================
  Files          19       19              
  Lines        2419     2421       +2     
  Branches      306      306              
==========================================
+ Hits         2313     2315       +2     
  Misses         93       93              
  Partials       13       13

@Julian
Copy link
Copy Markdown
Member

Julian commented Jul 12, 2019

Hi! Thanks so much.

Do you think you could give a shot at adding a simple test to the test suite?

Something simple like just making sure that __version__ in check_output(...) is probably good enough?

@vladmunteanu
Copy link
Copy Markdown
Contributor Author

Hello @Julian,

I have tried adding the test, verifying the full version string after stripping newlines.

I can't run the test suite locally because I can't get pyenv and tox to play nice with each other.
Besides that, pypy seems to fail and I can't figure out why at the moment.

@Julian Julian merged commit 9eea8df into python-jsonschema:master Jul 14, 2019
@Julian
Copy link
Copy Markdown
Member

Julian commented Jul 14, 2019

Thanks! Should just be that we need to make sure to run the right jsonschema CLI depending on the running Python, so just tacked a commit on top to do that.

Curious to hear more though about

I can't run the test suite locally because I can't get pyenv and tox to play nice with each other.

if you think the issue might not just be yours.

Otherwise thanks again!

@vladmunteanu
Copy link
Copy Markdown
Contributor Author

Thanks @Julian! And sorry I didn't figure out the stderr thing myself.

The problem I had with pyenv and tox has been fixed by running pyenv global <versions> before running tests, not sure if this is actually the recommended way.

@vladmunteanu vladmunteanu deleted the version-argument branch July 15, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make jsonschema --version work

2 participants