Conversation
Updates the requirements on ruamel-yaml to permit the latest version. --- updated-dependencies: - dependency-name: ruamel-yaml dependency-version: 0.19.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
github-merge-queue bot
pushed a commit
to meltano/meltano
that referenced
this pull request
Jan 28, 2026
…calls (#9726) <!-- Please, go through these steps when you submit a PR. 1. Make sure your branch is not protected. In particular, avoid making PRs from the `main` branch of your fork. 2. Give a descriptive title to your PR. We use semantic titles, and the accepted types and scopes are listed in https://github.com/meltano/meltano/blob/main/.github/semantic.yml. A good title should look like this: ``` feat(cli): The `meltano run` command now accepts a `--timeout` option to limit the time it runs ``` 3. Provide a description of your changes. 4. Put "Closes #XXXX" in your comment to auto-close the issue that your PR fixes (if such). --> ## Description <!-- Describe the changes introduced by this PR --> ## Related Issues * python-jsonschema/check-jsonschema#635 ## Summary by Sourcery Replace external check-jsonschema CLI usage with direct jsonschema-based manifest validation and extend tests to cover schema validation behavior and logging. Bug Fixes: - Ensure manifest schema validation logs include nested JSON path information for deeply nested schema violations. Enhancements: - Refactor manifest schema validation to use jsonschema.Draft7Validator directly instead of invoking the check-jsonschema subprocess. - Remove the unused check-jsonschema dependency from the project dependencies. Build: - Drop check-jsonschema from runtime dependencies in pyproject.toml. Tests: - Add tests verifying that valid manifests lint cleanly without schema warnings and that nested schema violations produce appropriate warning logs with nested paths. ## Summary by Sourcery Replace external manifest schema validation via the check-jsonschema CLI with direct jsonschema-based validation and improve how schema validation results are logged and tested. Bug Fixes: - Ensure schema validation warnings include precise JSON paths for root-level and nested manifest schema violations. Enhancements: - Introduce a cached jsonschema-based validator for the manifest schema instead of invoking the check-jsonschema subprocess. - Simplify manifest environment location discovery to use the loaded manifest schema data. - Improve schema validation warning formatting to aggregate and present all errors in a structured, readable message. Build: - Remove the check-jsonschema dependency from the project runtime dependencies. Tests: - Add tests to assert that valid manifests lint without schema warnings and that invalid manifests, including nested violations, produce appropriate warning logs with full JSON paths. --------- Signed-off-by: Edgar Ramírez Mondragón <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the requirements on ruamel-yaml to permit the latest version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)