MNT: explicitly cast away const-ness when calling CPython API

tacaswell · tacaswell · commit 9fe87462569a · 2022-04-30T16:48:48.000-04:00
diff --git a/src/greenlet/greenlet_refs.hpp b/src/greenlet/greenlet_refs.hpp
@@ -339,7 +339,7 @@ namespace greenlet {
             Py_XINCREF(other.p);
             const T* tmp = this->p;
             this->p = other.p;
-            Py_XDECREF(tmp);
+            Py_XDECREF(const_cast<T*>(tmp));
             return *this;
         }
 
@@ -851,7 +851,7 @@ namespace greenlet {
 
         void PyAddObject(const char* name, const PyObject* new_object)
         {
-            Py_INCREF(new_object);
+            Py_INCREF(const_cast<PyObject*>(new_object));
             try {
                 Require(PyModule_AddObject(this->p, name, const_cast<PyObject*>(new_object)));
             }

Original file line number	Diff line number	Diff line change
`@@ -339,7 +339,7 @@ namespace greenlet {`
`339`	`339`	`Py_XINCREF(other.p);`
`340`	`340`	`const T* tmp = this->p;`
`341`	`341`	`this->p = other.p;`
`342`		`- Py_XDECREF(tmp);`
	`342`	`+ Py_XDECREF(const_cast<T*>(tmp));`
`343`	`343`	`return *this;`
`344`	`344`	`}`
`345`	`345`
`@@ -851,7 +851,7 @@ namespace greenlet {`
`851`	`851`
`852`	`852`	`void PyAddObject(const char* name, const PyObject* new_object)`
`853`	`853`	`{`
`854`		`- Py_INCREF(new_object);`
	`854`	`+ Py_INCREF(const_cast<PyObject*>(new_object));`
`855`	`855`	`try {`
`856`	`856`	`Require(PyModule_AddObject(this->p, name, const_cast<PyObject*>(new_object)));`
`857`	`857`	`}`