Skip to content

Commit 9ff7d7a

Browse files
committed
Parametrize the special-characters rename test
1 parent df3e28f commit 9ff7d7a

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

‎tests/test_gen_dict.py‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,8 @@ class A:
253253
assert cve.value.exceptions[1].extra_fields == {"c"}
254254

255255

256-
def test_renaming_to_key_with_special_characters():
256+
@pytest.mark.parametrize("key", ["it's", 'a"b', "a'] or 1 or ['b"])
257+
def test_renaming_to_key_with_special_characters(key):
257258
"""A rename target is a dict key, so it may legitimately contain quotes.
258259
259260
It used to be interpolated into the generated code inside single quotes, so
@@ -264,17 +265,16 @@ def test_renaming_to_key_with_special_characters():
264265
class A:
265266
b: int
266267

267-
for key in ("it's", 'a"b', "a'] or 1 or ['b"):
268-
converter = Converter()
269-
converter.register_unstructure_hook(
270-
A, make_dict_unstructure_fn(A, converter, b=override(rename=key))
271-
)
272-
converter.register_structure_hook(
273-
A, make_dict_structure_fn(A, converter, b=override(rename=key))
274-
)
275-
276-
assert converter.unstructure(A(1)) == {key: 1}
277-
assert converter.structure({key: 1}, A) == A(1)
268+
converter = Converter()
269+
converter.register_unstructure_hook(
270+
A, make_dict_unstructure_fn(A, converter, b=override(rename=key))
271+
)
272+
converter.register_structure_hook(
273+
A, make_dict_structure_fn(A, converter, b=override(rename=key))
274+
)
275+
276+
assert converter.unstructure(A(1)) == {key: 1}
277+
assert converter.structure({key: 1}, A) == A(1)
278278

279279

280280
def test_omitting(converter: BaseConverter):

0 commit comments

Comments
 (0)