Skip to content

Fix attribute collection#635

Merged
hynek merged 12 commits intomasterfrom
fix-mro
Apr 6, 2020
Merged

Fix attribute collection#635
hynek merged 12 commits intomasterfrom
fix-mro

Conversation

@hynek
Copy link
Copy Markdown
Member

@hynek hynek commented Mar 30, 2020

This fixes #428 and has pestered me for a long while.

I'm not entirely sure how to go forward with the option, I guess I'll just set it to True in @attrs.define?

Anyhow, I this is the penultimate ticket stopping me from tackling the new APIs…

Comment thread changelog.d/428.change.rst Outdated
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
Comment thread changelog.d/635.change.rst Outdated
Comment thread changelog.d/428.change.rst
Comment thread src/attr/_make.py Outdated
Comment thread src/attr/_make.py
Comment thread src/attr/_make.py
Comment thread tests/test_make.py
@hynek hynek merged commit 33b6131 into master Apr 6, 2020
@hynek hynek deleted the fix-mro branch April 6, 2020 09:42
@jacobg
Copy link
Copy Markdown

jacobg commented Aug 18, 2020

This commit doesn't seem to work with slots. See related issue: #667

@hynek
Copy link
Copy Markdown
Member Author

hynek commented Aug 18, 2020

This commit is unrelated to #667.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MRO vs. inherited attributes

4 participants