Docs: clarify current behaviour/motivation for slots=True and autogeneration of __get/setstate__#521
Merged
hynek merged 9 commits intopython-attrs:masterfrom Jul 20, 2019
Conversation
andhus
changed the title
slots=True and autogeneration of __get/setstate__slots=True and autogeneration of __get/setstate__
10 tasks
andhus
commented
Mar 23, 2019
gabbard
reviewed
Mar 25, 2019
Co-Authored-By: andhus <[email protected]>
auvipy
approved these changes
Apr 24, 2019
hynek
approved these changes
Jul 20, 2019
Member
hynek
left a comment
hynek
left a comment
There was a problem hiding this comment.
I'm super sorry I've been procrastinating on this issue for so long, mostly because I was confused. Now I've finally double-checked the implementation and you're right.
Also you're right, we should make attrs more pickle-friendly, despite all its warts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This clarifies current behaviour wrt: #512
Pull Request Check List
(If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.)
.pyi).tests/typing_example.py.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives..rstfiles is written using semantic newlines.changelog.d.