Improve documentation of safety constraints on hashable objects#505
Merged
hynek merged 5 commits intopython-attrs:masterfrom Feb 14, 2019
Merged
Improve documentation of safety constraints on hashable objects#505hynek merged 5 commits intopython-attrs:masterfrom
hynek merged 5 commits intopython-attrs:masterfrom
Conversation
added 4 commits
October 31, 2018 17:04
Sync to main attrs repo
Sync up to attrs master
Sync up to main attrs repository
Makes clear that hashable objects need to be deeply immutable, in practice even if not in theory. Closes python-attrs#503 .
Member
Author
|
@hynek : Ready for review. |
hynek
approved these changes
Feb 14, 2019
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although #503 referred to
cache_hash, on reflection it occurred to me that the concern is valid for all hashable objects. At the same time, I've clarified the documentation to be clear that if you mutate acache_hashobject or an object referred to in its hash computation, the resulting object hash code is undefined. This seemed better than making any more particular comment since it leaves the API uncommitted as to whether the hash code is computed at object-construction time or lazily on the first call tohashThis closes #503 .
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
.pyi). (n/a, docs only)tests/typing_example.py. (n/a, docs only)docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives..rstfiles is written using semantic newlines.changelog.d.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!