Improve sentence parsing#470
Merged
hynek merged 1 commit intopython-attrs:masterfrom Dec 7, 2018
Merged
Conversation
I've always parsed this sentence as "attrs comes with serious, business aliases". I just realized you probably meant srs bzns aliases and figured I'd clarify.
|
Well, this requires research. Grammar Monster seems to agree, says that a compound adjective (as opposed to two adjectives that each apply) should be hyphenated for clarity… and with a name like Grammar Monster, it's hard to argue. So the question is whether @hynek meant that the aliases are both serious aliases and business aliases or whether he meant that they are "serious business" aliases. I've always assumed the latter, in which case this PR is correct. I'll leave it to @hynek to confirm. :-) |
Contributor
Author
|
Thank you for the extensive research, this echoes my thinking perfectly. We cannot make this change lightheartedly, so I salute your efforts to that end. |
Member
|
Obviously, I meant srs bzns duh. ;) |
hynek
approved these changes
Dec 7, 2018
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've always parsed this sentence as "attrs comes with serious, business aliases". I just realized you probably meant srs bzns aliases and figured I'd clarify.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
.pyi).tests/typing_example.py.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives..rstfiles is written using semantic newlines.changelog.d.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!