Skip to content

Fix typo#455

Merged
hynek merged 1 commit intopython-attrs:masterfrom
sloria:patch-1
Oct 26, 2018
Merged

Fix typo#455
hynek merged 1 commit intopython-attrs:masterfrom
sloria:patch-1

Conversation

@sloria
Copy link
Copy Markdown
Contributor

@sloria sloria commented Oct 26, 2018

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

  • Added tests for changed code.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changes to the signature of @attr.s() have to be added by hand too.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

@hynek hynek merged commit fdf053c into python-attrs:master Oct 26, 2018
@hynek
Copy link
Copy Markdown
Member

hynek commented Oct 26, 2018

Thanks!

@sloria sloria deleted the patch-1 branch January 17, 2019 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants