Add python_requires in setup.py#454
Merged
hynek merged 1 commit intopython-attrs:masterfrom Oct 25, 2018
williamjamir:patch-1
Merged
Add python_requires in setup.py#454hynek merged 1 commit intopython-attrs:masterfrom williamjamir:patch-1
hynek merged 1 commit intopython-attrs:masterfrom
williamjamir:patch-1
Conversation
This PR adds `python_requires` into `setup.py` to prevent `pip` from installing `attrs` in unsupported python versions. I know that currently `attrs` supports a wide range of python versions but I think that it's always good to have some sanity check =)
hynek
approved these changes
Oct 25, 2018
Member
|
Sure, why not, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
python_requiresintosetup.pyto preventpipfrom installingattrsin unsupported python versions.I know that currently
attrssupports a wide range of python versions but I think that it's always good to have some sanity check =)Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
.pyi).tests/typing_example.py.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives..rstfiles is written using semantic newlines.changelog.d.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!