Skip to content

Fix note in stubs#440

Merged
hynek merged 1 commit intopython-attrs:masterfrom
euresti:fix_note
Aug 29, 2018
Merged

Fix note in stubs#440
hynek merged 1 commit intopython-attrs:masterfrom
euresti:fix_note

Conversation

@euresti
Copy link
Copy Markdown
Contributor

@euresti euresti commented Aug 29, 2018

Fixes #415

Pull Request Check List

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

  • Added tests for changed code.
  • New features have been added to our Hypothesis testing strategy.
  • Changes or additions to public APIs are reflected in our type stubs (files ending in .pyi).
    • ...and used in the stub test file tests/typing_example.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) have news fragments in changelog.d.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

@hynek hynek merged commit 5b866d3 into python-attrs:master Aug 29, 2018
@hynek
Copy link
Copy Markdown
Member

hynek commented Aug 29, 2018

Thank you so much!

@euresti euresti deleted the fix_note branch February 18, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants