Make _Nothing a singleton#433
Merged
hynek merged 5 commits intopython-attrs:masterfrom Aug 27, 2018
Merged
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure how much the checklist makes sense for this change, given that there are no external or internal API changes.
This PR changes the
_Nothingclass to be a singleton. This allows a shorter class, as well as more reliance on inheritedobjectcode. Because they are all the same instance_Nothing() is _Nothing()will beTrue, and thus_Nothing() == _Nothing()will beTruewithout intervention. This will result in a slight performance boost.I have confirmed that this breaks no tests on my local machine under both 2.7 and 3.6
This is my first PR for the project, so I apologize in advance if there are any mistakes.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
.pyi).tests/typing_example.py.docs/api.rstby hand.versionadded,versionchanged, ordeprecateddirectives..rstfiles is written using semantic newlines.changelog.d.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!