Do not copy __weakref__ from original _cls_dict#410
Merged
hynek merged 2 commits intopython-attrs:masterfrom Jul 28, 2018
Merged
Do not copy __weakref__ from original _cls_dict#410hynek merged 2 commits intopython-attrs:masterfrom
hynek merged 2 commits intopython-attrs:masterfrom
Conversation
self._cls_dict["__weakref__"] holds a reference to self._cls, preventing self._cls from being released after the new, slots-enabled class is returned. Fixes python-attrs#407
njsmith
approved these changes
Jul 28, 2018
| pass | ||
|
|
||
| # The original C2 is in a reference cycle, so force a collect: | ||
| gc.collect() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
Thanks George & Nate! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #407 as discussed.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
.pyi)..rstfiles is written using semantic newlines.versionadded,versionchanged, ordeprecateddirectives.changelog.d.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!