Skip to content

Don't overwrite name with qualname for slots classes #99

@rdpate

Description

@rdpate

For slots classes, attr._make.attributes overwrites name with qualname. This shouldn't happen on Python 3. (Nothing happens on Python 2, as qualname is never set.) I think the correct fix is to change:

if repr_ns is None:
    cls_name = getattr(cls, "__qualname__", cls.__name__)
else:
    cls_name = cls.__name__

cls = type(cls_name, cls.__bases__, cls_dict)

To:

cls = type(cls.__name__, cls.__bases__, cls_dict)

However, this doesn't preserve qualname, and I fear I'm missing something else.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions