Skip to content

Conversation

@basnijholt
Copy link
Member

@basnijholt basnijholt commented Sep 25, 2021

Description

pin scikit-learn to 0.24.2, because of scikit-optimize/scikit-optimize#1059

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt basnijholt enabled auto-merge (squash) September 25, 2021 10:38
@codecov-commenter
Copy link

Codecov Report

Merging #333 (5923296) into master (d735270) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   80.72%   80.66%   -0.06%     
==========================================
  Files          38       38              
  Lines        5073     5073              
  Branches      921      921              
==========================================
- Hits         4095     4092       -3     
- Misses        837      838       +1     
- Partials      141      143       +2     
Impacted Files Coverage Δ
adaptive/learner/average_learner1D.py 78.51% <0.00%> (-1.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d735270...5923296. Read the comment docs.

@basnijholt basnijholt merged commit 68de8ed into master Sep 25, 2021
@basnijholt basnijholt deleted the fix/pin-sklearn branch September 25, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants