Add better default value for TypeVar default (PEP 696) #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should the default be not be public to allow people to check if a default wasn't passed? |
Contributor
Author
That was my first idea. However, it's not actually necessary. Take a look at |
JelleZijlstra
approved these changes
Oct 27, 2022
| @@ -1,3 +1,8 @@ | |||
| # Release 4.4.1 (?) | |||
Member
There was a problem hiding this comment.
Might end up being 4.5.0, but we can change that later.
Collaborator
There was a problem hiding this comment.
We should probably just use UNRELEASED in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #77 (comment)
/CC: @Gobot1234 @JelleZijlstra
This is a solution. Let me know if you had something different in mind.