Added draft chapter to typing spec for enumerations.#1591
Closed
erictraut wants to merge 27 commits intopython:mainfrom
Closed
Added draft chapter to typing spec for enumerations.#1591erictraut wants to merge 27 commits intopython:mainfrom
erictraut wants to merge 27 commits intopython:mainfrom
Conversation
AlexWaygood
reviewed
Jan 18, 2024
AlexWaygood
reviewed
Jan 18, 2024
AlexWaygood
reviewed
Jan 18, 2024
srittau
reviewed
Jan 18, 2024
beauxq
reviewed
Jan 18, 2024
debonte
reviewed
Jan 18, 2024
ethanfurman
reviewed
Jan 18, 2024
ethanfurman
reviewed
Jan 18, 2024
ethanfurman
reviewed
Jan 18, 2024
ethanfurman
reviewed
Jan 18, 2024
ethanfurman
reviewed
Jan 18, 2024
ethanfurman
reviewed
Jan 18, 2024
ethanfurman
reviewed
Jan 18, 2024
ethanfurman
suggested changes
Jan 18, 2024
Member
ethanfurman
left a comment
ethanfurman
left a comment
There was a problem hiding this comment.
Added some corrections and suggestions.
ethanfurman
reviewed
Jan 18, 2024
Co-authored-by: Ethan Furman <[email protected]>
5 tasks
| consistency. That is, if the type is assigned to a variable, the name of | ||
| the variable must match the name of the enum class:: | ||
|
|
||
| WrongName = Enum('Color', 'RED GREEN BLUE') # Type checker error |
Member
There was a problem hiding this comment.
Not sure this should be an error, commented on Discuss
rchen152
reviewed
Jan 23, 2024
…or enums declared with functional syntax.
… an attribute is a member.
Collaborator
Author
|
@JelleZijlstra, did mypy 1.9 fix the issue in stubtest that was blocking us from making the necessary changes in typeshed for enums? If not, is that something that could be prioritized for mypy 1.10? |
…'t apply to enum classes that derive from `enum.Flags` because these classes support enum members with values of zero and all combinations of the defined flags.
Co-authored-by: Hashem <[email protected]>
…ther an attribute is an enum member. Attributes with private (mangled) names are exempt.
stroxler
reviewed
May 23, 2024
Contributor
stroxler
left a comment
stroxler
left a comment
There was a problem hiding this comment.
Thanks for writing this, I've never actually known enum behavior as well as I should and learned quite a few things from reading.
|
The following commit authors need to sign the Contributor License Agreement:
Click the button to sign: |
| reveal_type(Color["RED"]) # Revealed type is 'Literal[Color.RED]' (or 'Color') | ||
| reveal_type(Color(3)) # Revealed type is 'Literal[Color.BLUE]' (or 'Color') | ||
|
|
||
| Unlike most Python classes, Calling an enum class does not invoke its constructor. |
Member
There was a problem hiding this comment.
Suggested change
| Unlike most Python classes, Calling an enum class does not invoke its constructor. | |
| Unlike most Python classes, calling an enum class does not invoke its constructor. |
carljm
approved these changes
Jun 1, 2024
Member
carljm
left a comment
carljm
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for writing this.
erictraut
added a commit
to erictraut/typing
that referenced
this pull request
Jun 3, 2024
This is the same set of changes as PR python#1591. The CI script that enforces CLA signing was confused, so it didn't permit merging the original PR.
Collaborator
Author
|
I'm not sure how to fix the CLA Signing issue with this PR, so I'm going to close it and submit a fresh PR. See #1759. |
erictraut
added a commit
that referenced
this pull request
Jun 3, 2024
This is the same set of changes as PR #1591. The CI script that enforces CLA signing was confused, so it didn't permit merging the original PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.