Update FilterType to retuning bool#9514
Merged
srittau merged 1 commit intopython:mainfrom Jan 16, 2023
KalleDK:patch-2
Merged
Conversation
The default Filter returns a bool and not an int
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: core (https://github.com/home-assistant/core)
+ homeassistant/components/zha/core/gateway.py:505: error: Argument 1 to "addFilter" of "Filterer" has incompatible type "Union[Filter, Callable[[LogRecord], int]]"; expected "Union[Filter, Callable[[LogRecord], bool]]" [arg-type]
+ homeassistant/components/zha/core/gateway.py:520: error: Argument 1 to "removeFilter" of "Filterer" has incompatible type "Union[Filter, Callable[[LogRecord], int]]"; expected "Union[Filter, Callable[[LogRecord], bool]]" [arg-type]
|
AlexWaygood
approved these changes
Jan 12, 2023
Member
There was a problem hiding this comment.
It looks like homeassistant just copied their type alias from the typeshed stub: https://github.com/home-assistant/core/blob/2ca73be9d0f02a00d65c9b05e7df5e06318adaff/homeassistant/components/zha/core/gateway.py#L94. So I think they'll just need to update thier type alias; I don't think they're actually passing callables that return int to this function.
Having said that, I'll leave this open in case any other maintainers have any thoughts, since the benefits also seem a little slim.
srittau
approved these changes
Jan 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default Filter returns a bool and not an int
Closes #5700