Skip to content

Check for unused pyright: ignore and differentiate from mypy ignores #9397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 8 commits into from
Dec 28, 2022
Merged

Check for unused pyright: ignore and differentiate from mypy ignores #9397

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
af804b6
Check for unused pyright: ignore
Avasam Dec 21, 2022
a2e8a20
Unused variable
Avasam Dec 21, 2022
70ee787
Update stubs/redis/redis/client.pyi
Avasam Dec 22, 2022
2d374cb
Merge branch 'main' into pyright-no-unused-pyright-ignore-comments
AlexWaygood Dec 26, 2022
7e02f34
Update comments and CONTRIBUTING.md
Avasam Dec 27, 2022
035fd4e
Merge branch 'pyright-no-unused-pyright-ignore-comments' of https://g…
Avasam Dec 27, 2022
9112e14
Merge branch 'main' of https://github.com/python/typeshed into pyrigh…
Avasam Dec 27, 2022
f1264a1
try moving comment
Avasam Dec 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
try moving comment
  • Loading branch information
@Avasam
Avasam committed Dec 27, 2022
commit f1264a17bd71ad6c1d58d22c97ade4728ae7d135
2 changes: 1 addition & 1 deletion stdlib/collections/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,8 @@ class _OrderedDictValuesView(ValuesView[_VT_co], Reversible[_VT_co]):
# The C implementations of the "views" classes
# (At runtime, these are called `odict_keys`, `odict_items` and `odict_values`,
# but they are not exposed anywhere)
@final
# pyright doesn't have a specific error code for subclassing error!
@final
class _odict_keys(dict_keys[_KT_co, _VT_co], Reversible[_KT_co]): # type: ignore[misc] # pyright: ignore
Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood Dec 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to add the pyright error codes for these pyright: ignores?

Copy link
Copy Markdown
Collaborator Author

@Avasam Avasam Dec 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no code!
image

Base class "dict_keys[_KT_co@_odict_keys, _VT_co@_odict_keys]" is marked final and cannot be subclassed Pylance

image

E:\Users\Avasam\Documents\Git\typeshed\stdlib\collections_init_.pyi
E:\Users\Avasam\Documents\Git\typeshed\stdlib\collections_init_.pyi:331:19 - error: Base class "dict_keys[_KT_co@_odict_keys, _VT_co@_odict_keys]" is marked final and cannot be subclassed

Copy link
Copy Markdown
Member

@AlexWaygood AlexWaygood Dec 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, strange! In that case, can we leave a comment to that effect? (Same below for the other one)

Suggested change
class _odict_keys(dict_keys[_KT_co, _VT_co], Reversible[_KT_co]): # type: ignore[misc] # pyright: ignore
# pyright doesn't have a specific error code for this error!
class _odict_keys(dict_keys[_KT_co, _VT_co], Reversible[_KT_co]): # type: ignore[misc] # pyright: ignore

def __reversed__(self) -> Iterator[_KT_co]: ...

Expand Down