tempfile.SpooledTemporaryFile: inherit from IOBase on 3.11 #7802
Conversation
This comment has been minimized.
This comment has been minimized.
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
I'd prefer us to use a wordier-but-more-readable alias name, like _SpooledTemporaryFileBase, rather than _STFBase which feels a bit opaque.
There was a problem hiding this comment.
It looks like in typeshed, we've always pretended that SpooledTemporaryFile has readable() and seekable() methods on Python <3.11 (see the comment on line 330), even though they don't at runtime. This is because SpooledTemporaryFile inherits from IO in typeshed, and IO has readable() and seekable() as abstract methods.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stdlib/tempfile.pyi
Outdated
| # It does not actually derive from IO[AnyStr], but it does mostly behave | ||
| # like one. |
There was a problem hiding this comment.
The comment should probably be moved down above the class itself.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
|
hm, I expected unused stubtest allowlist entries. I'll look into that in a followup PR. |
python/cpython#29560