builtins: add a getattr overload for bool#5518
Merged
JelleZijlstra merged 2 commits intopython:masterfrom May 29, 2021
Merged
Conversation
As brought up in python#5516 Alternatives include: - Use another type var that has a value restriction - Doing something fancy with Protocols that have a __bool__ that returns a Literal (which may not work) - Doing nothing
hauntsaninja
changed the title
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: pytest (https://github.com/pytest-dev/pytest.git)
- src/_pytest/config/__init__.py:1050: error: Argument 3 to "getattr" has incompatible type "bool"; expected "Optional[Namespace]" [arg-type]
tornado (https://github.com/tornadoweb/tornado.git)
- tornado/auth.py:323: error: Argument 3 to "getattr" has incompatible type "bool"; expected "Optional[str]"
|
JelleZijlstra
approved these changes
May 29, 2021
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Adding this for Python 2 also seems harmless
JukkaL
added a commit
to JukkaL/typeshed
that referenced
this pull request
Nov 22, 2021
These silence errors about missing type annotations for calls
like these:
```
x = getattr(o, 'a', [])
y = getattr(o, 'b', {})
```
This is a generalization of python#5518.
JukkaL
added a commit
that referenced
this pull request
Nov 22, 2021
These silence errors about missing type annotations for calls
like these:
```
x = getattr(o, 'a', [])
y = getattr(o, 'b', {})
```
This is basically a generalization of #5518 and other overloads we already
have.
This works around python/mypy#11572. I encountered the issue in several
places when testing recent typeshed against an internal repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As brought up in #5516
Alternatives include:
a Literal (which may not work)