Adjust types for asyncio.coroutines functions#5517
Merged
Conversation
Noticed this in mypy-primer output in #5516 on this code: https://github.com/encode/starlette/blob/master/starlette/testclient.py#L74 It calls `iscoroutinefunction()` on an object that may be None, which got flagged as an error but is actually fine; it just returns False. We could also potentially use TypeGuard here, especially for `iscoroutine` which is just an `isinstance` call.
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: aiohttp (https://github.com/aio-libs/aiohttp.git)
+ aiohttp/helpers.py:117: error: Incompatible redefinition (redefinition with type "Callable[[Callable[..., Any]], bool]", original type "Callable[[object], bool]") [misc]
|
Member
Author
|
That's https://github.com/aio-libs/aiohttp/blob/master/aiohttp/helpers.py#L113. Seems fine to force aiohttp to make a change here. I can send a PR to aiohttp once this PR is merged. |
hauntsaninja
approved these changes
May 21, 2021
srittau
approved these changes
May 21, 2021
JelleZijlstra
added a commit
to JelleZijlstra/aiohttp
that referenced
this pull request
May 21, 2021
This will be needed to make mypy pass after python/typeshed#5517 is released. The function accepts all objects, so `object` is the appropriate annotation, but `Any` is necessary for now here to make the conditional definition work with the previous type annotation.
webknjaz
pushed a commit
to aio-libs/aiohttp
that referenced
this pull request
May 22, 2021
This will be needed to make mypy pass after python/typeshed#5517 is released. The function accepts all objects, so `object` is the appropriate annotation, but `Any` is necessary for now here to make the conditional definition work with the previous type annotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this in mypy-primer output in #5516 on this code: https://github.com/encode/starlette/blob/master/starlette/testclient.py#L74
It calls
iscoroutinefunction()on an object that may be None, which got flagged as an error but is actually fine; it just returns False.We could also potentially use TypeGuard here, especially for
iscoroutinewhich is just anisinstancecall.