Merged
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Jul 13, 2024
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Nit: Could you move it between __init__ and guess_extension to match the implementation order? This makes it easier to compare implementation and stubs and keep them in sync.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Jul 13, 2024
5 tasks
max-muoto
pushed a commit
to max-muoto/typeshed
that referenced
this pull request
Jul 23, 2024
max-muoto
pushed a commit
to max-muoto/typeshed
that referenced
this pull request
Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow, it got lost when other methods were added 🙂