Update xml's Callable[..., Element] types (tag param in __init__)#10968
Merged
srittau merged 1 commit intopython:mainfrom Nov 3, 2023
Merged
Update xml's Callable[..., Element] types (tag param in __init__)#10968srittau merged 1 commit intopython:mainfrom
Callable[..., Element] types (tag param in __init__)#10968srittau merged 1 commit intopython:mainfrom
Conversation
Avasam
commented
Nov 2, 2023
| # lxml.etree._Element | ||
| # xml.etree.Element | ||
| class _HasTag(Protocol): | ||
| tag: Any # AnyOf[str, None, Callable[..., AnyOf[str, None]]] |
Collaborator
Author
There was a problem hiding this comment.
This strange Union was caused by Element's typing leading me to believe it could be Callable and the runtime implementation leading me to believe it could be None (see PR description).
Looking at xml.etree._Element typing from lxml-stubs as well as implementation of openpyxl looks like this is never assumed to be None neither.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Nov 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tagparam in__init__is typed asstr | Callable[..., Element], which really doesn't make sense to me looking at usages, and there's no comment explaining why. It really seems like thetagparameter ofElement.__init__should not beCallable.Sidenote, even though
Element.itertextdoes check for possibleNoneself.tag, the docstring and documentation do suggest it should only be astr. So I left them asstrand notstr | None.Relevant for #10967
Using re-assignement for
PI(as implementation does) just leads to better method signatures.