Add support to build aarch64 wheels#182
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
.github/workflows/build.yml
Outdated
| env: | ||
| CIBW_BUILD: "cp${{ matrix.python-version }}-*" | ||
| CIBW_SKIP: "*-manylinux_i686 *-win32" | ||
| CIBW_SKIP: "*-manylinux_i686 *-win32 *-macosx_arm64" |
There was a problem hiding this comment.
Is this intentional? We still want arm64 wheels for macOS right?
There was a problem hiding this comment.
Yes, added it back to be keep it same as before
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thank you! Sorry, between waiting for the CLA business and the holidays this got a little bit lost. Just had one question :-)
|
Hmm, looks like aarch64 build hung on Python 3.10. Let me try kicking it, in case it was a fluke. |
@hauntsaninja On my branch I was able to get aarch64 build on python 3.10 successfully. https://github.com/tbbharaj/typed_ast/actions/runs/1713796535 |
|
@hauntsaninja Does this look good to merge? |
|
Yup, thanks for your patience. It's a little unfortunate that the build seems flakey, but we'll see how bad of a problem that is going forward. I'll release a 1.5.2 with aarch64 wheels. |
|
Thanks, 1.5.2 is out! |
Thank you! |
See more: python/typed_ast#182 (comment) (cherry picked from commit c699686)
3 participants
In reference to issue #180, created this PR to add support for aarch64 wheels.
Happy to address any feedbacks!
Successful builds: https://github.com/tbbharaj/typed_ast/actions/runs/1546050914
Thank you