Skip to content

PEP 750: major updates to "Template Strings" based on community feedback#4062

Merged
AA-Turner merged 173 commits intopython:mainfrom
davepeck:pep750-post-sprint-update
Oct 22, 2024
Merged

PEP 750: major updates to "Template Strings" based on community feedback#4062
AA-Turner merged 173 commits intopython:mainfrom
davepeck:pep750-post-sprint-update

Conversation

@davepeck
Copy link
Contributor

@davepeck davepeck commented Oct 16, 2024 •
edited by hugovk
Loading

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

This PR contains substantial updates to PEP 750 based on feedback from the broader Python community, including comments on the official PEP Discourse thread and in-person core team feedback at the recent Bellevue, WA, USA sprint.

It has been reviewed by:

Koudai Aono (@koxudaxi) and I were both added as co-authors.

Basic requirements (all PEP Types)

  • Read and followed PEP 1 & PEP 12
  • File created from the latest PEP template
  • PEP has next available number, & set in filename (pep-NNNN.rst), PR title (PEP 123: <Title of PEP>) and PEP header
  • Title clearly, accurately and concisely describes the content in 79 characters or less
  • Core dev/PEP editor listed as Author or Sponsor, and formally confirmed their approval
  • Author, Status (Draft), Type and Created headers filled out correctly
  • PEP-Delegate, Topic, Requires and Replaces headers completed if appropriate
  • Required sections included
    • Abstract (first section)
    • Copyright (last section; exact wording from template required)
  • Code is well-formatted (PEP 7/PEP 8) and is in code blocks, with the right lexer names if non-Python
  • PEP builds with no warnings, pre-commit checks pass and content displays as intended in the rendered HTML
  • Authors/sponsor added to .github/CODEOWNERS for the PEP

Standards Track requirements

  • PEP topic discussed in a suitable venue with general agreement that a PEP is appropriate
  • Suggested sections included (unless not applicable)
    • Motivation
    • Rationale
    • Specification
    • Backwards Compatibility
    • Security Implications
    • How to Teach This
    • Reference Implementation
    • Rejected Ideas
    • Open Issues
  • Python-Version set to valid (pre-beta) future Python version, if relevant
  • Any project stated in the PEP as supporting/endorsing/benefiting from the PEP formally confirmed such (not relevant?)
  • Right before or after initial merging, PEP discussion thread created and linked to in Discussions-To and Post-History (the existing Discourse thread is found here )

📚 Documentation preview 📚: https://pep-previews--4062.org.readthedocs.build/pep-0750/

davepeck and others added 30 commits September 27, 2024 13:36
@davepeck
Start work on post-sprint PEP 750 update.
988967a
@davepeck
Let's get started
33939ee
@koxudaxi
Update PEP 750 to use Template and Interpolation classes in a proposa…
8a62a48 
…l part
@koxudaxi
Update Specification section in PEP 750
e3300fe
@koxudaxi
Fix interpolation attributes in examples
3d917d7
@koxudaxi
Update Specification
f4ba6fe
@koxudaxi
Add Raw Template Strings
babe2c2
@koxudaxi
Merge pull request #1 from koxudaxi/pep750-post-sprint-update
1656dc1 
Update PEP 750 to use Template and Interpolation classes in a proposal part
@koxudaxi
Update PEP 750: Adjust class definition and usage
4bc3307 
Modified the `Interpolation` class definition, changing it from a `Protocol` to a regular class. Updated various instances in the PEP to reflect changes in syntax and terminology, replacing `tag function` with `template function` where appropriate.
@koxudaxi
Refactor tag strings to template strings
42265a7
@koxudaxi
Refactor PEP 750 terminology from 'tag' to 'template' strings
3e13a69
@koxudaxi
Refactor PEP 750 terminology from 'tag' to 'template' strings
e4f1554
@koxudaxi
Refactor PEP 750 terminology from 'tag' to 'template' strings
427194e
@koxudaxi
Update Memoizing
1bd26d0
@koxudaxi
Revert example code
3841518
@koxudaxi
Strip mytag
4be9d4a
@davepeck
Many updates. Starting to get there, maybe?
b0e9523
@davepeck
Minor updates.
171cf15
@davepeck
Merge branch 'main' into pep750-post-sprint-update
65d17ab
@davepeck
Shrubbery
c38bf3d
@davepeck
Minor update
2fa44a9
@davepeck
Minor update
dca351b
@davepeck
Update
b433491
@davepeck
Hello no comma
79bbc52
@davepeck
Format specification
fd8c97e
@davepeck
Clarify
bead99c
@davepeck
Particular
e149e33
@davepeck
Better words
53fb3a4
@davepeck
Odd length
231caf6
@davepeck
Structured
06c2ef6
AA-Turner
AA-Turner reviewed Oct 19, 2024
View reviewed changes
davepeck and others added 11 commits October 21, 2024 07:58
@davepeck
After extensive discussion, allow concatenation.
2c8f806
@davepeck
Merge branch 'main' into pep750-post-sprint-update
6372f48
@davepeck @AA-Turner
Remove unnecessary that
f404cdf 
Co-authored-by: Adam Turner <[email protected]>
@davepeck @AA-Turner
Fix heading length
06fb769 
Co-authored-by: Adam Turner <[email protected]>
@davepeck @AA-Turner
Remove needless extra "and"
e2690d1 
Co-authored-by: Adam Turner <[email protected]>
@davepeck @AA-Turner
Clarify what we mean about bringing logic to Python
0836d12 
Co-authored-by: Adam Turner <[email protected]>
@davepeck @AA-Turner
Better writing in "interleaving" section
cd1ee92 
Co-authored-by: Adam Turner <[email protected]>
@davepeck @AA-Turner
Update peps/pep-0750.rst
2ef8267 
Co-authored-by: Adam Turner <[email protected]>
@davepeck
You add some egg and you lose some too.
249ccc4
@davepeck
Merge branch 'main' into pep750-post-sprint-update
9b66afd
@davepeck
Clarify template and interpolation equality and mutability.
5401b48
jimbaker
jimbaker reviewed Oct 21, 2024
View reviewed changes
AA-Turner
AA-Turner approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting up with me @davepeck! This seems in a good state to merge (I've left a comment on templatelib on the thread, but it's non editorial.)

Do you have anything outstanding before merging? We should probably get this in before it hits 200 commits, and anything missed can be covered in a follow up.

Thank you again!

A

@davepeck
Copy link
Contributor Author

davepeck commented Oct 21, 2024

Thank you for putting up with me @davepeck!

On the contrary, thank you for putting up with me and my zillion edits! :-)

This seems in a good state to merge (I've left a comment on templatelib on the thread, but it's non editorial.)

Yes, at this point, I think we can merge. We'll need another turn of the crank for sure, but it's in a good place for now.

nineteendo
nineteendo reviewed Oct 21, 2024
View reviewed changes
@davepeck @nineteendo
Update peps/pep-0750.rst
f45519f 
Co-authored-by: Nice Zombies <[email protected]>
@AA-Turner AA-Turner merged commit d3b4ab6 into python:main Oct 22, 2024
@AA-Turner
Copy link
Member

AA-Turner commented Oct 22, 2024

Thanks @davepeck!

A

ncoghlan pushed a commit to ncoghlan/peps that referenced this pull request Oct 23, 2024
@davepeck @koxudaxi
@pauleveritt @lysnikolaou @AA-Turner @nineteendo @ncoghlan
PEP 750: major updates to "Template Strings" based on community feedb…
98e657b 
…ack (python#4062)

Co-authored-by: Koudai Aono <[email protected]>
Co-authored-by: pauleveritt <[email protected]>
Co-authored-by: Lysandros Nikolaou <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Nice Zombies <[email protected]>
gvanrossum pushed a commit to gvanrossum/peps that referenced this pull request Dec 10, 2024
@davepeck @koxudaxi
@pauleveritt @lysnikolaou @AA-Turner @nineteendo @gvanrossum
PEP 750: major updates to "Template Strings" based on community feedb…
40a9fea 
…ack (python#4062)

Co-authored-by: Koudai Aono <[email protected]>
Co-authored-by: pauleveritt <[email protected]>
Co-authored-by: Lysandros Nikolaou <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Nice Zombies <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@willingc willingc willingc approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

+3 more reviewers

@jimbaker jimbaker jimbaker left review comments

@nineteendo nineteendo nineteendo left review comments

@InSyncWithFoo InSyncWithFoo InSyncWithFoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@davepeck @lysnikolaou @AA-Turner @jimbaker @JelleZijlstra @willingc @nineteendo @InSyncWithFoo @koxudaxi @pauleveritt