Build and deploy HTML on GitHub Actions#1669
Merged
brettcannon merged 2 commits intopython:masterfrom Oct 23, 2020
Merged
Conversation
Member
|
I'm guessing that @ewdurbin would know? |
Member
|
I'm happy to take this if @ewdurbin can get us the secret necessary for the upload and what envvar to set it in. |
Member
|
|
Member
|
Awesome, so merging this should be enough to get stuff working? Yay! |
Member
|
@pradyunsg not quite. While Ernest was nice enough to store the secrets, the workflow needs to be updated to actually set those values as environment variables. |
Member
Author
|
Ah yes, updated! DemoI added some dummy values in my fork. With another branch, before setting env vars, fails to find credentials (as expected): After adding env vars, found them (and dummy values didn't work, as expected): |
Member
|
I just merged this and the first run worked! So I have gone ahead and removed the Travis webhook and configuration file. Thanks, @hugovk |
Member
Author
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Split from #1570.)
Adds a GitHub Actions workflow to build and deploy, like Travis CI.
Notes:
Travis CI builds against 3.7 and 3.7-dev. I only added 3.8 to GHA. Should it build against a range? For example, we can do 3.6-3.9.
It will only deploy for
python/pepsandmaster(like Travis)I've left Travis CI in place for now. I'd suggest confirming the deploy works first from GHA, then removing from Travis in a followup PR.
(I also noticed that on Travis, it's deploying for both 3.7 and 3.7-dev. It probably only needs doing from a single job.)
Nice bonus:
make -j$(nproc)is quicker on GHA (~80s) than Travis (~110s)TODO
https://travis-ci.com/github/python/peps? They will need to be added at https://github.com/python/peps/settings/secrets