Allow strict in config, explicitly disallow inline#8192
Merged
msullivan merged 2 commits intopython:masterfrom Feb 21, 2020
Merged
Allow strict in config, explicitly disallow inline#8192msullivan merged 2 commits intopython:masterfrom
msullivan merged 2 commits intopython:masterfrom
Conversation
Collaborator
|
What's the rationale for explicitly disallowing in inline configuration? |
Contributor
Author
|
Mainly to fix the current situation: specifying it inline doesn't work, and ends up displaying a misleading error message about configuration files (not inline config), currently: After: If I remember correctly, making it work for inline config would not have been a quick fix. The details escape me at the moment. Anyway, the rubber duck tells me that I should improve that message somewhat though; rebase and improvement coming in a jiffy. |
73a3532 to
c32dfe5
Compare
andersk
added a commit
to andersk/mypy
that referenced
this pull request
Sep 17, 2021
Historically --strict was only supported on the command line, but commit cb0ceb0 (python#8192) added this option to the config file in 0.770. Signed-off-by: Anders Kaseorg <[email protected]>
JelleZijlstra
pushed a commit
that referenced
this pull request
Sep 19, 2021
Historically --strict was only supported on the command line, but commit cb0ceb0 (#8192) added this option to the config file in 0.770. Signed-off-by: Anders Kaseorg <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.