Conversation
This comment has been minimized.
This comment has been minimized.
|
Great, of course the tests fail! |
|
It looks like the errors coming from CPython and psutil? I wonder if the tests would pass on a Python 3.9 debug build (or on an even more recent Python). |
|
The first error is from here: https://github.com/python/cpython/blob/63e54e6d4227e7cbdbb2a0ea69d11a904951f3a9/Objects/typeobject.c#L3129. This likely means we're calling I don't know what the psutil error is about. My first thought was that the release and debug ABIs were not yet compatible in 3.8, but Victor already made them compatible in 3.8 (python/cpython@f4e4703). Regardless, it's probably not worth trying to get these tests to pass on 3.8. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
47c7308 to
a82e3dc
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
I tried to reproduce the psutil error standalone, but haven't yet been able to. The PyErr_Occurred and LookupError are probably less mysterious. Putting this down for now, will pick it up later. |
eba5a38 to
be06e95
Compare
be06e95 to
323f657
Compare
This comment has been minimized.
This comment has been minimized.
Taken from python/cpython@dcda92f I temporarly disabled some checks due to #17822
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
Tests still have issues, but going to merge to remove the fully broken setup |
Fixes #17819