Regression test for make_simplified_union truthiness#15098
Merged
JelleZijlstra merged 1 commit intopython:masterfrom Apr 21, 2023
Merged
Regression test for make_simplified_union truthiness#15098JelleZijlstra merged 1 commit intopython:masterfrom
JelleZijlstra merged 1 commit intopython:masterfrom
Conversation
Add a test for the code path exercised in python#15094
AlexWaygood
approved these changes
Apr 21, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM! Makes sense as a regression test, and definitely fails with #15094 applied :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test for the code path exercised in #15094