Doc: Add Optional in Decorator factories #14156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypy complains about error: Incompatible default for argument "__func" (default has type "None", argument has type "Callable[..., Any]") [assignment] note: PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True This change adds Optional around "Callable[..., Any]] = None"
hauntsaninja
approved these changes
Nov 21, 2022
Collaborator
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Nice, thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Situation
The documentation shows an example in the "Decorator factories" section and it looks like this:
However, if you save the file and run mypy, it complains about the previous line:
Proposed change
This change adds Optional around
Callable[..., Any]]which avoids the above error message.