Update pos-only unit tests for Python 3.10.7#13660
Update pos-only unit tests for Python 3.10.7#13660hauntsaninja merged 4 commits intopython:masterfrom
Conversation
hauntsaninja
left a comment
hauntsaninja
left a comment
There was a problem hiding this comment.
Thanks for fixing! Although maybe check-python38 should automatically set --python-version 3.8? Eh, this is fine and tests automagically setting flags has tripped me up before
|
(looks like CI is running with 3.10.6 so I'm just gonna trust that you got everything) |
It surprised me that it didn't! But also it's consistent with |
I fixed all the ones I found in failing CI runs, but then I just tried upgrading to Python 3.10.7 locally, and I found a bunch more 🤷♂️. I've just updated the PR to fix those as well. |
…#13660) The CI has started to sporadically fail depending on whether 3.10.6 is picked up by GitHub Actions (okay) or 3.10.7 (not okay). For example: - https://github.com/python/mypy/actions/runs/3046671132/jobs/4909772702 - https://github.com/python/mypy/actions/runs/3046723692/jobs/4909887963 On Python 3.10.7 (but not on Python 3.10.6), mypy correctly rejects using PEP 570 syntax unless `--python-version` is set to 3.8 or higher (this is due to python/cpython#95935). However, this makes several unit tests fail. This PR updates those unit tests so that the CI passes on both 3.10.6 and 3.10.7
#13665) Backport #13660 to fix test issues with Python 3.10.7. https://github.com/python/mypy/actions/runs/3046723692/jobs/4909887963 Co-authored-by: Alex Waygood <[email protected]>
2 participants
Description
The CI has started to sporadically fail depending on whether 3.10.6 is picked up by GitHub Actions (okay) or 3.10.7 (not okay). For example:
On Python 3.10.7 (but not on Python 3.10.6), mypy correctly rejects using PEP 570 syntax unless
--python-versionis set to 3.8 or higher (this is due to python/cpython#95935). However, this makes several unit tests fail.This PR updates those unit tests so that the CI passes on both 3.10.6 and 3.10.7