Refactoring: Remove the "erased" attribute of Instance #12499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used for anything.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| # in typeshed. However, this is really more of an implementation detail of how Enums | ||
| # are typed, and we really don't want to treat every single Enum value as if it were | ||
| # from type variable substitution. So we reset the 'erased' field here. | ||
| return itype.copy_modified(erased=False, last_known_value=enum_literal) |
Collaborator
There was a problem hiding this comment.
Docstring should be modified too
Collaborator
Author
There was a problem hiding this comment.
Removed the comment.
AlexWaygood
reviewed
Mar 31, 2022
mypy/expandtype.py
Outdated
| repl = get_proper_type(self.variables.get(t.id, t)) | ||
| if isinstance(repl, Instance): | ||
| inst = repl | ||
| # Return copy of instance with type erasure flag on. |
Member
There was a problem hiding this comment.
Suggested change
| # Return copy of instance with type erasure flag on. | |
| # Return copy of instance. |
mypy/expandtype.py
Outdated
| repl = get_proper_type(self.variables.get(t.id, t)) | ||
| if isinstance(repl, Instance): | ||
| inst = repl | ||
| # Return copy of instance with type erasure flag on. |
Member
There was a problem hiding this comment.
Suggested change
| # Return copy of instance with type erasure flag on. | |
| # Return copy of instance. |
JelleZijlstra
approved these changes
Mar 31, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not used for anything.