Adds StrEnum support for python3.11
#12035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Jan 21, 2022
test-data/unit/lib-stub/enum.pyi
Outdated
|
|
||
| # It is python-3.11+ only: | ||
| class StrEnum(str, Enum): | ||
| def __new__(cls: Type[_T], value: int | _T) -> _T: ... |
Member
There was a problem hiding this comment.
Over at typeshed I corrected this to
def __new__(cls: Type[_T], value: str | _T) -> _T: ...
Member
Author
There was a problem hiding this comment.
Yes, sure. This is a typo. Thanks!
Member
There was a problem hiding this comment.
No problem — thanks for working on the PR! 😀
Member
|
Did we turn off 3.11 CI completely? I don't see it in the list. |
Collaborator
|
Yeah we just turned if off. #12003 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there are already a couple of alpha versions available, I think it might be a good idea to add support for some new python features.
For example, now subclasses of
StrEnumwill be treated as realEnums!