Skip to content

[dev] audit -skip tests #20881

Open
Open

Description

@wyattscarpenter

A number of the tests marked -skip seem to be out of date and should be either

  1. enabled
  2. removed
    or
  3. switched to -xfail

Activity

  1. wyattscarpenter commented on Feb 24, 2026

    @wyattscarpenter
    ContributorAuthor

    Based on a brief sampling of these in #20889, I think most of them are just -skip when they should be -xfail. There are two benefits, both admittedly marginal, to making them xfail instead of skip: 1. It is semantically correct (at least according to my interpretation of https://docs.pytest.org/en/stable/how-to/skipping.html) 2. If they get fixed they will be reported as an unexpected xpass, instead of silently continuing to skip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions