Skip to content

Commit 9e0e23e

Browse files
authored
mypy_primer: don't fail silently on comment failure (#10012)
Fixes #10011 I think this is just vestigial from some initial debugging Co-authored-by: hauntsaninja <>
1 parent e43be0d commit 9e0e23e

1 file changed

Lines changed: 7 additions & 11 deletions

File tree

‎.github/workflows/mypy_primer_comment.yml‎

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -94,15 +94,11 @@ jobs:
9494
9595
console.log("Diff from mypy_primer:")
9696
console.log(data)
97-
try {
98-
if (data.trim()) {
99-
await github.issues.createComment({
100-
issue_number: context.issue.number,
101-
owner: context.repo.owner,
102-
repo: context.repo.repo,
103-
body: 'Diff from [mypy_primer](https://github.com/hauntsaninja/mypy_primer), showing the effect of this PR on open source code:\n```diff\n' + data + '```'
104-
})
105-
}
106-
} catch (error) {
107-
console.log(error)
97+
if (data.trim()) {
98+
await github.issues.createComment({
99+
issue_number: context.issue.number,
100+
owner: context.repo.owner,
101+
repo: context.repo.repo,
102+
body: 'Diff from [mypy_primer](https://github.com/hauntsaninja/mypy_primer), showing the effect of this PR on open source code:\n```diff\n' + data + '```'
103+
})
108104
}

0 commit comments

Comments
 (0)