Fix NotADirectory error when calling files on a subdirectory of a zipped namespace package#293
Merged
jaraco merged 6 commits intopython:mainfrom Feb 25, 2024
Conversation
… namespace package
jaraco
force-pushed
the
wzhao-fix-files-not-a-directory-when-reading-submodule-of-a-zipped-namespace-package
branch
from
aba2a7e to
d93e241
Compare
jaraco
approved these changes
Feb 25, 2024
Member
jaraco
left a comment
jaraco
left a comment
There was a problem hiding this comment.
This looks really good. I appreciate the attention to detail, such as changing comments that would have been made invalid, maintaining consistency in the test approach, and adding new tests for missing coverage. You rock. I have a couple of comments, but I plan to address those myself. Thanks for the contrib!
…ory is a multiplexed path to avoid touching implementation details.
…re's less chance of accidentally matching one for the other.
Member
|
Released with 6.1.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #294
To make sure this is tested, I adds a subdirectory to the namespace01 in the test data, and by the way adding tests for zipped namespace package to make sure all other features are working correctly in this case.