-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
GH-66285: skip asyncio fork tests for platforms without md5 hash #99745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit d450015 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
Other tests which use multiprocessing also skips test with this decorator. cpython/Lib/test/_test_multiprocessing.py Line 3534 in ae185fd
The refleaks are unrelated. |
|
Doesn’t seem to have helped. Let’s roll back the other and start over. |
|
@gvanrossum: The previously broken builtbot now passes with this PR https://buildbot.python.org/all/#/builders/713/builds/844. The refleaks exists on main too and is unrelated, see @ambv message on discord python-dev. Do you see any other issue with this? |
gvanrossum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM. Once we have conformation from @ambv this can be merged.
… md5 hash (python#99745)" This reverts commit 679d963.
python#99745) Such buildbots (at the time of writing, only "AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x") cannot use multiprocessing with a fork server, so just skip the test there.
Uh oh!
There was an error while loading. Please reload this page.