gh-99537: Use Py_SETREF(var, NULL) in C code #99687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "Py_DECREF(var); var = NULL;" with "Py_SETREF(var, NULL);".
vstinner
requested review from
abalkin,
markshannon,
pganssle and
tiran
as code owners
Member
Author
|
@erlend-aasland: I wrote PR #99686 to replace For me, Py_SETREF() is easier because I don't have to think: hum, should DECREF be called before or after setting the variable to the new value (NULL)? From my point of view, it looks like an "atomic" which is always "correct" (when used properly: when the variable already contains a strong reference). |
Contributor
Sorry, I forgot about this! IMO, this change improves readability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "Py_DECREF(var); var = NULL;" with "Py_SETREF(var, NULL);".