gh-99377: Revert audit events for thread state creation and free, because the GIL is not properly held at these times #99543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… actually been set. This can occur during initialization. Without the check, later calls to get the interpreter state will cause a fatal error.
zooba
added
skip news
🔨 test-with-buildbots
bedevere-bot
removed
the
🔨 test-with-buildbots
ericsnowcurrently
approved these changes
Nov 16, 2022
Member
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
I'm surprised _PyThreadState_SetCurrent() can leave it NULL though. Something seems fishy there.
Member
Author
|
This hasn't done it. Going to revert most of the change (I'll leave the |
Member
|
FYI, I'm double-checking that that PR was the culprit: gh-99545. |
Member
|
Looks like a full revert passes all buildbots (actually, 7 still running), so it seems like we're right that the original PR is the source of the failures. |
Member
|
This also closes #99544 |
zooba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can occur during initialization. Without the check, later calls to get the interpreter state will cause a fatal error.