gh-94199: Remove ssl.wrap_socket() documentation#99023
gh-94199: Remove ssl.wrap_socket() documentation#99023vstinner merged 5 commits intopython:mainfrom vstinner:ssl_doc
Conversation
The function has been removed. In the ssl documentation, replace references to the ssl.wrap_socket() function with references to the ssl.SSLContext.wrap_socket() method.
bedevere-bot
added
awaiting core review
docs
|
cc @illia-v |
illia-v
left a comment
illia-v
left a comment
There was a problem hiding this comment.
Thanks for updating the doc!
Some arguments of ssl.wrap_socket are no longer present in SSLContext.wrap_socket.
|
@illia-v: I updated my PR, would you mind to review it? I removed references to non-existing parameters. I made it clear the wrap_socket() is now the only way to create SSL socket objects, as already stated in the SSLSocket documentation: https://docs.python.org/dev/library/ssl.html#ssl.SSLSocket
|
| case, only the ``certfile`` parameter to :meth:`SSLContext.load_cert_chain` | ||
| and :func:`wrap_socket` needs to be passed. If the private key is stored | ||
| and :meth:`SSLContext.wrap_socket` needs to be passed. If the private key is stored |
There was a problem hiding this comment.
SSLContext.wrap_socket has no certfile parameter
Co-authored-by: Illia Volochii <[email protected]>
Co-authored-by: Illia Volochii <[email protected]>
|
Thanks @illia-v, it was more complicated than expected. Not just a simple text replace before/after ;-) |
3 participants
The function has been removed. In the ssl documentation, replace references to the ssl.wrap_socket() function with references to the ssl.SSLContext.wrap_socket() method.