gh-97545: Make Semaphore run faster.#97549
Merged
gvanrossum merged 2 commits intopython:mainfrom Sep 26, 2022
Merged
Conversation
cykerway
requested review from
1st1,
asvetlov and
gvanrossum
as code owners
cykerway
changed the title
gvanrossum
reviewed
Sep 26, 2022
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
I've run through this code so many times in my mind, this looks good to me. The silly speed test I wrote to flag this problem runs as fast as it used to. So I'll just merge this and backport to 3.11.
gvanrossum
approved these changes
Sep 26, 2022
Contributor
|
Thanks @cykerway for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-97584 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2022
(cherry picked from commit 68c46ae) Co-authored-by: Cyker Way <[email protected]>
Contributor
|
Thanks @cykerway for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
|
GH-97585 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2022
(cherry picked from commit 68c46ae) Co-authored-by: Cyker Way <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 26, 2022
(cherry picked from commit 68c46ae) Co-authored-by: Cyker Way <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 27, 2022
(cherry picked from commit 68c46ae) Co-authored-by: Cyker Way <[email protected]>
pablogsal
pushed a commit
that referenced
this pull request
Oct 24, 2022
(cherry picked from commit 68c46ae) Co-authored-by: Cyker Way <[email protected]>
pablogsal
pushed a commit
that referenced
this pull request
Oct 24, 2022
(cherry picked from commit 68c46ae) Co-authored-by: Cyker Way <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-97545: Make Semaphore run faster.
For this to be a fifo semaphore, the asyncio loop shall run tasks in their waking order (to be confirmed).
Background:
asyncio.Semaphoreand strengthen FIFO guarantee. #93222asyncio.{Lock,Semaphore}.locked()return True when there are waiters? #97028Tests:
Lib/test/test_asyncio/test_locks.py