gh-89536: Use ThinLTO policy if possible#96766
Merged
corona10 merged 2 commits intopython:mainfrom Sep 16, 2022
Merged
Conversation
Member
Author
Member
Author
|
I will wait for @ned-deily 's review as the final reviewer since he is the expert on macOS releases. |
Contributor
|
Should we do a performance benchmark of the generated executable? |
Member
Author
|
@matthiasgoergens |
Contributor
|
Thanks! Ha, I should learn how this |
Member
Author
|
@ned-deily @methane cc @matthiasgoergens Here is the latest benchmark with my local macOS environment(not fully isolated) when applying only LTO optimization. |
Member
Author
|
Here is the PGO + LTO benchmark (consistently 3-4% faster :)) |
methane
approved these changes
Sep 13, 2022
Member
Author
|
Thank you @ronaldoussoren and @methane |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--with-ltoflag (AS-IS: LTO): 112.02 secs--with-ltoflag (TO-BE: ThinLTO): 56.150 secs (almost 2x faster)Both builds were done with M1 Pro CPU