gh-96168: Improve sqlite3 dict_factory example #96457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use dict comprehension - use doctest iso. testcode, for visualising the effect of the row factory - SELECT with multiple columns, so the effect of the row factory becomes clearer
erlend-aasland
added
needs backport to 3.11
ezio-melotti
approved these changes
Aug 31, 2022
CAM-Gerlach
reviewed
Sep 1, 2022
Member
CAM-Gerlach
left a comment
CAM-Gerlach
left a comment
There was a problem hiding this comment.
A couple minor comments, otherwise LGTM 👍 It looks a lot clearer to me than before, as well as more testable, concise and following more modern coding practices.
Co-authored-by: C.A.M. Gerlach <[email protected]>
Contributor
Author
|
Thanks for the reviews, CAM & Ezio! |
Contributor
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-96494 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 1, 2022
Co-authored-by: C.A.M. Gerlach <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 91f40f3) Co-authored-by: Erlend E. Aasland <[email protected]>
|
GH-96495 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 1, 2022
Co-authored-by: C.A.M. Gerlach <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 91f40f3) Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 1, 2022
Co-authored-by: C.A.M. Gerlach <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 91f40f3) Co-authored-by: Erlend E. Aasland <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Sep 1, 2022
Co-authored-by: C.A.M. Gerlach <[email protected]> Co-authored-by: Ezio Melotti <[email protected]> (cherry picked from commit 91f40f3) Co-authored-by: Erlend E. Aasland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
effect of the row factory
the row factory becomes clearer