[3.11] gh-95736: Fix event loop creation in IsolatedAsyncioTestCase (GH-96033)#96041
Closed
miss-islington wants to merge 1 commit intopython:3.11from
Closed
[3.11] gh-95736: Fix event loop creation in IsolatedAsyncioTestCase (GH-96033)#96041miss-islington wants to merge 1 commit intopython:3.11from
miss-islington wants to merge 1 commit intopython:3.11from
Conversation
…ythonGH-96033) It should be created before calling the setUp() method, but after checking for skipping a test. Automerge-Triggered-By: GH:tiran (cherry picked from commit 3651710) Co-authored-by: Serhiy Storchaka <[email protected]>
Contributor
Author
|
@serhiy-storchaka: Status check is done, and it's a failure ❌ . |
Contributor
Author
|
@serhiy-storchaka: Status check is done, and it's a failure ❌ . |
Contributor
|
This needs manual backport with tests. |
Contributor
Author
|
Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be created before calling the setUp() method, but after
checking for skipping a test.
Automerge-Triggered-By: GH:tiran
(cherry picked from commit 3651710)
Co-authored-by: Serhiy Storchaka [email protected]
IsolatedAsyncioTestCasedoes not callasyncio.set_event_loopbeforesetUpanymore,asyncio.Runner+PidFdChildWatcherleaves zombie processes #95736