[3.10] gh-94996: Disallow parsing pos only params with feature_version < (3, 8)#95935
Merged
miss-islington merged 2 commits intopython:3.10from Aug 12, 2022
Merged
Conversation
… < (3, 8) (pythonGH-94997) (cherry picked from commit b5e3ea2)
…version < (3, 8) (pythonGH-94997). (cherry picked from commit b5e3ea2) Co-authored-by: Shantanu <[email protected]>
lysnikolaou
approved these changes
Aug 12, 2022
Contributor
|
Status check is done, and it's a success ✅ . |
hauntsaninja
pushed a commit
to python/mypy
that referenced
this pull request
Sep 14, 2022
The CI has started to sporadically fail depending on whether 3.10.6 is picked up by GitHub Actions (okay) or 3.10.7 (not okay). For example: - https://github.com/python/mypy/actions/runs/3046671132/jobs/4909772702 - https://github.com/python/mypy/actions/runs/3046723692/jobs/4909887963 On Python 3.10.7 (but not on Python 3.10.6), mypy correctly rejects using PEP 570 syntax unless `--python-version` is set to 3.8 or higher (this is due to python/cpython#95935). However, this makes several unit tests fail. This PR updates those unit tests so that the CI passes on both 3.10.6 and 3.10.7
cdce8p
pushed a commit
to cdce8p/mypy
that referenced
this pull request
Sep 14, 2022
…#13660) The CI has started to sporadically fail depending on whether 3.10.6 is picked up by GitHub Actions (okay) or 3.10.7 (not okay). For example: - https://github.com/python/mypy/actions/runs/3046671132/jobs/4909772702 - https://github.com/python/mypy/actions/runs/3046723692/jobs/4909887963 On Python 3.10.7 (but not on Python 3.10.6), mypy correctly rejects using PEP 570 syntax unless `--python-version` is set to 3.8 or higher (this is due to python/cpython#95935). However, this makes several unit tests fail. This PR updates those unit tests so that the CI passes on both 3.10.6 and 3.10.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit b5e3ea2)
Co-authored-by: Shantanu [email protected]
Automerge-Triggered-By: GH:lysnikolaou