bpo-19756: Change remote NNTP server to localhost server for most tests #9461
Conversation
berkerpeksag
changed the title
* Local server is based on the existing NNTPv2Handler class * Reintegrate test_starttls() into NetworkedNNTPTestsMixin * Only test_with_statement() talks to the remote NNTP_HOST now * Make tests in NetworkedNNTPTestsMixin stricter, because the server responses are predetermined now * Add mock comp.lang.python support to NNTPv1Handler.handle_GROUP() * Add support for rejecting passwords in NNTPv1Handler.handle_AUTHINFO() * New message number with non-UTF-8 message body for ARTICLE, HEAD, BODY, and non-UTF-8 subject for OVER, XOVER Initial patch by Martin Panter.
|
What is the status of this PR? Was it already merged? Should it be merged? |
|
I think we can close this PR and its old issue because the nntplib module is deprecated in 3.11 and set for removal in 3.13? See PEP 594 – Removing dead batteries from the standard library and #91217. |
|
@berkerpeksag Hi, I am trying to recreate nntplib as an independent module on https://sr.ht/~mcepl/nntplib/ . It builds successfully with the original code, but when I apply this PR (with some attempts to make it work for Python 3.10) https://git.sr.ht/~mcepl/nntplib/tree/testing-localhost the test suite fails. I have apparently got lost somewhere around the |
I agree. Given that this PR solely concerns tests, given that the PR has been open for over 3 years without activity, and given that the module has no active maintainer in the core dev team, I'm closing this PR as per the policy in the dev guide. |
6 participants
responses are predetermined now
non-UTF-8 subject for OVER, XOVER
Initial patch by Martin Panter.
https://bugs.python.org/issue19756