gh-90997: Show cached inline values in dis output #92360
gh-90997: Show cached inline values in dis output #92360pablogsal merged 6 commits intopython:mainfrom
dis output #92360Conversation
|
Looks good, but it should have at least one test. |
|
LGTM |
|
This PR is failing on the buildbots: https://buildbot.python.org/all/#/builders/244/builds/2311/steps/5/logs/stdio Please, prepare a fix ASAP or I would need to revert it :( |
|
@brandtbucher @markshannon can you take a look? |
|
Looking at it now. The s390x failures suggest that this may be due to endianness. My initial hunch is that this test uncovered a bug in how we're reading and writing caches (which should be in native byte order). |
|
The test seems to only be failing on big-endian architectures when the caches are actually populated with non-zero values. The symptom looks like messed-up parsing of nearby instructions (in this case, a |
|
New theory: I think |
This adds the actual values stored in
CACHEentries to the "argrepr" field ofdisoutput whenshow_caches=True.Example:
@pablogsal, since this aids in debugging our new adaptive/specialized instructions and inline caches, I'd prefer to get this into 3.11 if possible. If you agree, please feel free to merge while I'm sleeping or whatever.