bpo-34641: Further restrict the LHS of keyword argument function call syntax.#9212
Merged
bpo-34641: Further restrict the LHS of keyword argument function call syntax.#9212
Conversation
serhiy-storchaka
approved these changes
Sep 12, 2018
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
The code LGTM. Added just two nitpicks.
Python/ast.c
Outdated
| return NULL; | ||
| } | ||
| else if (e->kind != Name_kind) { | ||
| } else if (TYPE(expr_node) != NAME) { |
Member
There was a problem hiding this comment.
For PEP 7, break a line after "}".
| @@ -0,0 +1,2 @@ | |||
| Further restrict the syntax of the left-hand side of keyword arguments in | |||
| function calls. In particular, ``f((arg)=default)`` is now disallowed. | |||
Member
There was a problem hiding this comment.
default looks a bad name. It is not function definition, but a function call.
serhiy-storchaka
approved these changes
Sep 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue34641